Changelist

Bug Fix: /transfers/parentSubaccountNumber returning only ~10 results instead of respecting limit

Problem:
The /transfers/parentSubaccountNumber endpoint was incorrectly returning only 10-11 transfers even when no limit was specified (default should be 1000).

Root Cause:
The endpoint had a two-step process:

1. Query database for up to 1000 transfers involving all child subaccounts of a parent
2. Filter out same-parent transfers (e.g., transfers between subaccount 0 and subaccount 128, both parent 0) in memory

When a parent subaccount had many internal transfers between its children, the database would return 1000 transfers (mostly same-parent), filter them out, and leave only ~10 cross-parent transfers.

Solution:

• Created new database function findAllToOrFromParentSubaccount() that filters same-parent transfers at the SQL level
• Uses LEFT JOINs with the subaccounts table to filter transfers where both sender and recipient have the same address AND same parent subaccount number (subaccountNumber % 128)
• The SQL filter runs BEFORE the LIMIT is applied, ensuring the correct number of cross-parent transfers are returned

Changes:

1. New Database Function (packages/postgres/src/stores/transfer-table.ts)

   • Added findAllToOrFromParentSubaccount() with SQL-level filtering
   • Added ParentSubaccountTransferQueryConfig interface
   • Filters same-parent transfers using: (sender_sa.subaccountNumber % 128) = (recipient_sa.subaccountNumber % 128)

2. Updated Controller (indexer/services/comlink/src/controllers/api/v4/transfers-controller.ts)

   • Modified getTransfersForParentSubaccount() to use new database function
   • Removed in-memory filtering logic (now handled in SQL)

Test Plan

Key Test Cases

1. Same-parent filtering: Verified transfers between child subaccounts of same parent (e.g., 0→128) are excluded
2. Cross-parent transfers: Verified transfers between different parents (e.g., parent 0→parent 1) are included
3. Deposits/Withdrawals: Verified wallet↔subaccount transfers are included
4. Limit validation: Created 35 same-parent + 15 cross-parent transfers, verified all 15 cross-parent transfers returned (not just 10)
5. Pagination: Verified pagination works correctly with SQL-level filtering

Manul Testing on Staging

curl "https://indexer.v4staging.dydx.exchange/v4/transfers/parentSubaccountNumber?address=dydx1nzuttarf5k2j0nug5yzhr6p74t9avehn9hlh8m&parentSubaccountNumber=0" | jq '{transferCount: (.transfers | length), totalResults: .totalResults, pageSize: .pageSize, offset: .offset}'

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  427k  100  427k    0     0   278k      0  0:00:01  0:00:01 --:--:--  278k
{
  "transferCount": 1000,
  "totalResults": null,
  "pageSize": null,
  "offset": null
}

Now it retrieves up the API limit - 1,000

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Transfer query updated to exclude transfers between child subaccounts of the same parent and to support pagination, height/time filters, and deposits/withdrawals.

• Behavior Changes

  • API now returns the raw transformed transfer results from the parent-aware query (client-side parent filtering removed).

• Tests

  • Comprehensive tests added/updated to cover cross-parent vs same-parent transfers, pagination, limits, and edge cases.